Skip to content

feat: upgraded custom measure editor #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shahzeelahmed wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

feat: upgraded custom measure editor #741

shahzeelahmed wants to merge 34 commits into from

Conversation

@shahzeelahmed
Copy link
Member

@shahzeelahmed shahzeelahmed commented Jan 8, 2026 •
edited
Loading

  • pre-validation of python syntax and ibis function usage in measures
  • improved UI
  • fixes variable assignment
  • error messages shown in UI with suggestions
  • available columns and functions list
    Before:
image

After:

custom_measure.mov

@shahzeelahmed shahzeelahmed changed the title feat: implement expression validation with error handling feat: upgraded custom measure editor Jan 8, 2026
@shahzeelahmed shahzeelahmed marked this pull request as draft January 9, 2026 05:20
@shahzeelahmed
feat: add measure name and data type inputs to NewMeasureSelectorDialog
4a17002
@shahzeelahmed
chore: better colors for code editor
5aab92c
@shahzeelahmed
fix: align error text with icon
b1b4544
@shahzeelahmed
feat: enhance function search input with icon and improved layout
6ead6b6
@shahzeelahmed
chore: improve styling
4fed398
@shahzeelahmed
chore: formatting
7d8f812
@shahzeelahmed
feat: improve validation ui
b6f48cc
@shahzeelahmed
chore: remove collapsible section
86149ca
@shahzeelahmed
fix: adjust validation error display and increase function section he…
c54c741 
…ight
@shahzeelahmed
fix: update validation message styling and adjust layout for better r…
4a69bbd 
…eadability
@shahzeelahmed
fix(style): maintain proper padding
5e0e3c1
@shahzeelahmed
fix(style): decrease code editor height
33ee19f
@shahzeelahmed
feat: include columns with functions list
4053f01
@shahzeelahmed
Merge remote-tracking branch 'upstream/develop' into custom-measure
4ebb669
@shahzeelahmed
fix(ui): rounded dialog border
6ce3f8e
@shahzeelahmed
feat(ui): remove signature element
4b3b67d
@shahzeelahmed
feat(validation): add validation linter for error diagnostics
71f388b
@shahzeelahmed shahzeelahmed marked this pull request as ready for review January 19, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shahzeelahmed